Re: Circular dependency for gmake with nls and PREFER_PKGSRC=yes

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

Le 2019-10-20 18:07, Frédéric Fauberteau a écrit :
> Le 2019-10-20 17:55, Frédéric Fauberteau a écrit :
> > Le 2019-10-20 17:11, Frédéric Fauberteau a écrit :
> > > Le 2019-10-20 16:15, Frédéric Fauberteau a écrit :
> > > > ERROR: This package has set PKG_FAIL_REASON:
> > > > ERROR: Circular dependency detected
> > > > *** Error code 1
> > > >
> > > > Stop.
> > > > bmake[3]: stopped in /mnt/ccd0/pkgsrc/devel/gmake
> > > > *** Error code 1
> > > >
> > > > Stop.
> > > > bmake[2]: stopped in /mnt/ccd0/pkgsrc/devel/ncurses
> > > > *** Error code 1
> > > >
> > > > Stop.
> > > > bmake[1]: stopped in /mnt/ccd0/pkgsrc/devel/gettext-tools
> > > > *** Error code 1
> > > >
> > > > Stop.
> > > > bmake: stopped in /usr/pkgsrc/devel/gmake
> > > >
> > > > Could we disable PREFER_PKGSRC only for devel/gettext-tools building
> > > > if nls option is enabled for devel/gmake?
> > >
> > > Is it correct?
> > >
> > > .include "../../mk/bsd.options.mk"
> > >
> > > .if !empty(PKG_OPTIONS:Mnls)
> > > USE_BUILTIN.gettext=    yes
> > > .  include "../../devel/gettext-lib/buildlink3.mk"
> >
> > If there is no native gettext implementation, nls should not be built
> > for GNU make.
> >
> > This seems better:
> >
> > .include "../../mk/bsd.options.mk"
> >
> > .include "../../devel/gettext-lib/builtin.mk"
> > .if !empty(PKG_OPTIONS:Mnls) && \
> >     !empty(IS_BUILTIN.gettext:M[yY][eE][sS])
> > PREFER.gettext=   native
> > .  include "../../devel/gettext-lib/buildlink3.mk"
> >
> > I just have a doubt about USE_BUILTIN.gettext=yes vs
> > PREFER.gettext=native. Which one should be better?
>
> # PREFER.<pkg>
> is exhibited by mk/buildlink3/bsd.builtin.mk but USE_BUILTIN.<pkg>
> seems to be an internal variable.

But PREFER.gettext=native does not work whie USE_BUILTIN.gettext=yes 
does.