Re: cwrappers and "" empty quoted arguments

[coypu%sdf.org@localhost]

On Fri, Aug 02, 2019 at 04:21:35PM +0000, coypu%sdf.org@localhost wrote:
> hi folks,
> 
> I have an issue with the updated version of mono, wip/mono6.
> it builds fine outside of pkgsrc, but cwrappers seems to break its use
> of the command line.
> 
> It's running commands like:
> 
> MONO_PATH="./../../class/lib/build:$MONO_PATH" /home/fly/pkgsrc/wip/mono6/work/mono-6.0.0.313/runtime/mono-wrapper  ./../../class/lib/build/gen
> sources.exe --basedir:./Test --strict --platformsdir:./../../build "../../build/deps/_xbuild_12_Microsoft.Build.Framework_test.dll.sources" "Mi
> crosoft.Build.Framework_test.dll" "" "xbuild_12"
> 
> And I suspect cwrappers doesn't like the use of "" and drops it (?) so
> the build misbehaves.
> Quoting it as \"\" helps.
> 

The following patch helps.

diff --git a/pkgtools/cwrappers/files/bin/common.c b/pkgtools/cwrappers/files/bin/common.c
index 3d2b8266e4c..0672e2200ec 100644
--- a/pkgtools/cwrappers/files/bin/common.c
+++ b/pkgtools/cwrappers/files/bin/common.c
@@ -137,8 +137,10 @@ arglist_from_argc(struct arglist *args, int argc, char **argv)
        TAILQ_INIT(args);
 
        for (--argc, ++argv; argc; --argc, ++argv) {
+#if 0
                if (**argv == '\0')
                        continue;
+#endif
                arg = argument_copy(*argv);
                TAILQ_INSERT_TAIL(args, arg, link);             
        }