Re: make: Unclosed substitution for CONFIGURE_DIRS (] missing)

[Roland Illig <roland.illig%gmx.de@localhost>]

Am 01.07.2019 um 18:51 schrieb Edgar Fuß:
> It looks like the change introduced in pkgsrc/mk/configure/configure.mk 1.28
> confuses at least my ancient (NetBSD-4) make. Escaping the pound sign with
> a backslash seems to correct the problem:
>
> diff -u -r1.29 configure.mk
> --- configure/configure.mk      7 May 2019 19:36:44 -0000       1.29
> +++ configure/configure.mk      1 Jul 2019 16:47:06 -0000

> -.  if ${CONFIGURE_DIRS:[#]} != 1
> +.  if ${CONFIGURE_DIRS:[\#]} != 1

> I've no idea whether the escaped pund sign confuses modern versions of make.

It was me who introduced this change. I hadn't expected that anyone
would use the current pkgsrc with a make(1) from 4 years earlier.
Apparently I was wrong.

The version with the escaped hash works in all versions of NetBSD make
since at least 2008. Modern versions don't have a problem. The
corresponding code is in devel/bmake/files/parse.c, search for '['.