On 29 June 2018 at 17:16, <maya%netbsd.org@localhost> wrote: > On Fri, Jun 29, 2018 at 11:11:45AM -0400, Greg Troxel wrote: >> >> Because it needs gcc 6.1 !! >> > > Deviating from upstream requirement for compiler is a riskier choice for > freeze. > > Documentation to require c++11 is to shove -std=gnu++11 as a flag, > upstream could be doing it themselves. > > This was necesssary because libraries made headers which require C++11 to > use, and further downstream packages did not adjust flags yet. Following up on my mail re https://bugzilla.mozilla.org/show_bug.cgi?format=default&id=1444274 On at least NetBSD-8 amd64 firefox appears to build and run fine if you stub out the gcc version check and force --std=c++14 Notes: - I don't know for certain whether --std=c++14 is needed or if --std=c++11 would work - I'm trying another build with std=c++11 - I'm not familiar with the firefox build framework, so for this test I just hacked in --std=c++14 to the optimise flags, so this is not ready for commit - Even if firefox builds with gcc 5.5 now, its safe to assume it will start to require 6.1 at some point, so if we put something in for this it should only be considered a temporary fix for netbsd-8/firefox61 However, having said that, patch for options.mk and other patch attached David
Attachment:
patch-build_moz.configure_toolchain.configure
Description: Binary data
? patches/patch-build_moz.configure_toolchain.configure Index: options.mk =================================================================== RCS file: /cvsroot/pkgsrc/www/firefox/options.mk,v retrieving revision 1.44 diff -u -r1.44 options.mk --- options.mk 10 Dec 2017 00:45:09 -0000 1.44 +++ options.mk 29 Jun 2018 17:10:54 -0000 @@ -62,7 +62,7 @@ CONFIGURE_ARGS+= --disable-debug-symbols .endif CONFIGURE_ARGS+= --disable-debug -CONFIGURE_ARGS+= --enable-optimize=-O2 +CONFIGURE_ARGS+= --enable-optimize="-O2 --std=c++14" CONFIGURE_ARGS+= --enable-install-strip .endif