Re: firefox breakage - how to fix?

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

I do not have enough time to check the build recently.
In one or two weeks, I will restore my build environment in my new room.

Of course please feel free to fix the www/firefox build.

Thank you.

From: Greg Troxel <gdt%lexort.com@localhost>, Date: Thu, 29 Jun 2017 10:29:28 -0400

> 
> I've seen some discussion, but firefox is still broken.  On netbsd-7
> amd64 with system gcc (arguably the primary platform for pkgsrc), it
> fails with
> 
>   In file included from /u0/n0/gdt/NetBSD-current/pkgsrc/www/firefox/work/build/ipc/chromium/Unified_cpp_ipc_chromium0.cpp:74:0:
>   /u0/n0/gdt/NetBSD-current/pkgsrc/www/firefox/work/firefox-54.0/ipc/chromium/src/base/lock_impl_posix.cc: In constructor 'base::internal::LockImpl::LockImpl()':
>   /u0/n0/gdt/NetBSD-current/pkgsrc/www/firefox/work/firefox-54.0/ipc/chromium/src/base/lock_impl_posix.cc:35:46: error: 'PTHREAD_PRIO_INHERIT' was not declared in this scope
>        rv = pthread_mutexattr_setprotocol(&mta, PTHREAD_PRIO_INHERIT);
> 
> 
> I saw talk of patching netbsd-7, but that isn't a fix for pkgsrc, which
> should work with formal releases.
> 
> It looks like somehing in chromium source was updated to use a feature
> in NetBSD-current on all NetBSD, which seems wrong.  Can we just patch
> this to pretend that PTHREAD_PRIO_INHERIT doesn't exist if it's not
> defined?  Or always, if that's easier?

--
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3