tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pre-pkgsrc-2017Q1: security/policykit fails on MacOS



> On Mar 23, 2017, at 4:05 PM, Jonathan Perkin <jperkin%joyent.com@localhost> wrote:
> 
> Something has changed recently but I didn't finish tracking down
> exactly what.  Basically -nonet is overridden by another argument (I
> forget what now) and it goes via the net regardless.
> 
> This is what I was working around with this commit:
> 
>  https://github.com/joyent/pkgsrc/commit/40a618833d833bd01600904cdc0ac0ba4055e7e6
> 
> and we might want to do similar in other cases.

Thanks for the pointer.  The following patch allows it to build successfully.

$NetBSD$

--- doc/man/Makefile.in.orig	2017-03-23 23:58:10.000000000 +0000
+++ doc/man/Makefile.in
@@ -554,7 +554,7 @@ uninstall-man: uninstall-man1 uninstall-
 
 
 @MAN_PAGES_ENABLED_TRUE@%.1 %.5 %.8 : %.xml
-@MAN_PAGES_ENABLED_TRUE@	$(XSLTPROC) -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl $<
+@MAN_PAGES_ENABLED_TRUE@	$(XSLTPROC) -nonet ${PREFIX}/share/xsl/docbook/manpages/docbook.xsl $<
 
 clean-local:
 	rm -f *~ *.1 *.5 *.8

It does lead to the following messages, though:

Making all in man
/Users/brook/pkg-2017Q1/bin/xsltproc -nonet /Users/brook/pkg-2017Q1/share/xsl/docbook/manpages/docbook.xsl polkit-auth.xml
Warn: meta author : no refentry/info/author                        polkit-auth
Note: meta author : see http://docbook.sf.net/el/author            polkit-auth
Warn: meta author : no author data, so inserted a fixme            polkit-auth
Note: Writing polkit-auth.1
/Users/brook/pkg-2017Q1/bin/xsltproc -nonet /Users/brook/pkg-2017Q1/share/xsl/docbook/manpages/docbook.xsl polkit-action.xml
Warn: meta author : no refentry/info/author                        polkit-action
Note: meta author : see http://docbook.sf.net/el/author            polkit-action
Warn: meta author : no author data, so inserted a fixme            polkit-action
Note: Writing polkit-action.1
/Users/brook/pkg-2017Q1/bin/xsltproc -nonet /Users/brook/pkg-2017Q1/share/xsl/docbook/manpages/docbook.xsl polkit-config-file-validate.xml
Warn: meta author : no refentry/info/author                        polkit-config-file-validate
Note: meta author : see http://docbook.sf.net/el/author            polkit-config-file-validate
Warn: meta author : no author data, so inserted a fixme            polkit-config-file-validate
Note: Writing polkit-config-file-validate.1
/Users/brook/pkg-2017Q1/bin/xsltproc -nonet /Users/brook/pkg-2017Q1/share/xsl/docbook/manpages/docbook.xsl polkit-policy-file-validate.xml
Warn: meta author : no refentry/info/author                        polkit-policy-file-validate
Note: meta author : see http://docbook.sf.net/el/author            polkit-policy-file-validate
Warn: meta author : no author data, so inserted a fixme            polkit-policy-file-validate
Note: Writing polkit-policy-file-validate.1
/Users/brook/pkg-2017Q1/bin/xsltproc -nonet /Users/brook/pkg-2017Q1/share/xsl/docbook/manpages/docbook.xsl PolicyKit.conf.xml
Note: Writing PolicyKit.conf.5
/Users/brook/pkg-2017Q1/bin/xsltproc -nonet /Users/brook/pkg-2017Q1/share/xsl/docbook/manpages/docbook.xsl PolicyKit.xml
Note: Writing PolicyKit.8

I assume that they can be safely ignored.

Shall I commit this or does anyone wish to weigh in otherwise?

Cheers,
Brook



Home | Main Index | Thread Index | Old Index