Re: The sad state of pkgsrc [was Re: pkgsrc NetBSD 7.0.1_PATCH/x86_64 2016-09-04 11:03]

[Mark Davies <mark%ecs.vuw.ac.nz@localhost>]

On 07/09/16 08:46, Joerg Sonnenberger wrote:
> > emulators/qemu                             2 pkgsrc-users%NetBSD.org@localhost
>
> gcc: Missing argument for -o
> multiboot.raw: option ROM does not begin with magic 55 aa


Below patch appears to fix.  Anyone see an issue with it?

$NetBSD$

Dont need "-o -" to go to stdout

--- pc-bios/optionrom/Makefile.orig     2016-09-02 15:34:22.000000000 +0000
+++ pc-bios/optionrom/Makefile
@@ -43,7 +43,7 @@ build-all: multiboot.bin linuxboot.bin l


 %.o: %.S
-       $(call quiet-command,$(CPP) $(QEMU_INCLUDES) $(QEMU_DGFLAGS) -c 
-o - $< | $(AS) $(ASFLAGS) -o $@,"  AS    $(TARGET_DIR)$@")
+       $(call quiet-command,$(CPP) $(QEMU_INCLUDES) $(QEMU_DGFLAGS) -c 
$< | $(AS) $(ASFLAGS) -o $@,"  AS    $(TARGET_DIR)$@")

 %.img: %.o
        $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m 
$(LD_I386_EMULATION) -T $(SRC_PATH)/pc-bios/optionrom/flat.lds -s -o $@ 
$<,"  Building $(TARGET_DIR)$@")


cheers
mark