Re: Making mk/subst.mk more robust

[David Holland <dholland-pkgtech%netbsd.org@localhost>]

On Sat, Jan 30, 2016 at 01:52:33PM +0100, Roland Illig wrote:
 > currently, the SUBST framework in mk/subst.mk may lead to file
 > corruption during active package development. This happens when a sed(1)
 > command has a syntax error, so that the whole command is terminated. In
 > such a case, the original file becomes empty.
 > 
 > The appended patch fixes that by applying the sed(1) commands to the
 > original file and saving the result in a temporary file. Only after that
 > succeeded is the original file overwritten.
 > 
 > The one tricky part is the SUBST_POSTCMD, which relies on the exact
 > procedure from before the patch. But since it is only used in exactly
 > one place (mk/wrapper), not by any packages in either main pkgsrc or
 > pkgsrc-wip, I would like to remove that variable.
 > 
 > Thoughts?

Seems fine to me.

-- 
David A. Holland
dholland%netbsd.org@localhost