Re: Removing APACHE_CUSTOM_CFLAGS

[Pierre Pronchery <khorben%defora.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

			Hey,

On 01/20/16 14:04, Greg Troxel wrote:
> Pierre Pronchery <khorben%defora.org@localhost> writes:
>> I would like to know if it would be fine to remove support for
>> the APACHE_CUSTOM_CFLAGS variable in pkgsrc. It is not used by
>> default, and breaks normal support for CFLAGS in
>> www/apache{22,24}.
>> 
>> Is anyone using this? If yes, I will welcome alternative
>> solutions allowing support for CFLAGS and APACHE_CUSTOM_CFLAGS
>> together.
> 
> This seems reasonable to remove.

Ok, will do.

> If anything, we should have support for setting custom cflags on a 
> per-package basis in mk.conf, rather than an open-coded version of
> that abstraction in particular makefiles.

I definitely agree.

> However, I do wonder what the motivation was for adding this.  Did
> the commit message that added it say anything useful?  The comments
> in the Makefile do not.  (Really the explanation/justification
> belongs in the Makefile.)

It dates back to 2001, from bsd.pkg.defaults.mk (1.1), which was
itself inspired from mk.conf.example:

Author: jlam <jlam>
Date:   Fri May 18 06:01:35 2001 +0000

    Introduce a new make variable APACHE_CUSTOM_CFLAGS that can be set
    in /etc/mk.conf to any string of legal compiler flags to tune
    different aspects of the built httpd.

Cheers,
- -- 
khorben
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWn4pAAAoJEDA4y9uYhpcDDPUQAI7vC5lk97iIV12KDLi7cgNp
YzJi/Zg0i7PxNnVl611EHM22qm7CRwrA7pFcZIZljfjgIGxz35p59YfeTUsaL3OA
BJ7iwqjNhbQIQP55MNLRnyjPaiflbdNDIAdmpbXAiY9iuZy62cOWFFvqipOQTWG2
MDBGCfMREgsRzIwBLpLWAl4LAeS4l33MfVSqyRgkFSAUg+zzM3vyUsm3auTg+DUa
1QnqyUJLFVEsZatfECfN7LBxP/HfmC2pBqyHi0vM7lEl5LtW0QhlERBx/299OQ8d
mUtI3PpacvHdJxmDoQ/++hPn3dqbCgx9fg+RmmlHhCYguNXzrk8d72tcOsIS1aG3
9eqTSVgX7181iqIEZ9d65ivpi4WzpLqEeaINmBQjd5KDlwsiRl9GgECJw2ix+ZhT
HYBZC8mYwKxegsqdx16bPoC4mdUODfpaCnc6hkDjievQpVfcCMKPdoJGwJrMMzr3
ZifTrDp6utY6/POiJObWKTCahtL69PNs587rTvefcxfa08Vjg7TFYum2rTy5lAuu
3++M3ZxFTOBIKtyKN/fTeLhzsfa/NYJ1kvbMBbKLfz8mephMsRVYOxbsS2bkqAeo
igBc0TGmhlYMt7F5rRdFrFnRBBRGT9J+NPWN6P7Wi0dBqyFIqm0QqjS3j6HXPCaY
kV5dZaMgJ/P7HoPnUMYw
=dONs
-----END PGP SIGNATURE-----