Re: Use the newly introduced GIT_ENV instead of tweaking a supposedly internal variable.

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Nov 13, 2015 at 04:32:14PM +0100, Hauke Fath wrote:
> On Fri, 13 Nov 2015 11:31:14 +0100, Thomas Klausner wrote:
> > Why is this necessary for these particular three packages, that all
> > reside on github, and not all the other github packages?
> > 
> > To me this looks like a local setup problem (missing certificates)
> > that is papered over...
> 
> It is a local setup problem, I'll grant you, in that NetBSD does not 
> ship with a cert store; and I don't know what pkgsrc has in that area, 
> nor how it is integrated with potential clients (wget, git). Arguably, 
> this should be fixed in pkgsrc.

It is.
Take a look at

security/mozilla-rootcerts
security/mozilla-rootcerts-openssl

It will not install these for you, and I think that's fine too.

> Nevertheless, the "only four" packages adapted make clear that there is 
> a legitimate need to parametrize git access, which wip's 
> mk/git-package.mk only allowed for by tweaking supposedly internal 
> variables through the back door.
> 
> Same argument, btw., for exporting a GIT_FLAGS variable.

I have no problem with adding a way to set flags to git.mk, but the
packages should use it this way to disable certificate checking.
 Thomas