Re: TMPDIR and bsd.pkg.mk (was Re: clang builds and /var/tmp)

[Richard PALO <richard%netbsd.org@localhost>]

In addition to ncurses, so far I've come across dbus as well, for platforms other than Darwin.
> => Checking for work-directory references in dbus-1.10.0nb1
> ERROR: /opt/local/bin/dbus-cleanup-sockets:	Binary file /home/pbulk/build32/sysutils/dbus/work/.destdir/opt/local/bin/dbus-cleanup-sockets matches
> ERROR: /opt/local/share/dbus-1/session.conf:	  <listen>unix:tmpdir=/home/pbulk/build32/sysutils/dbus/work/.home</listen>
> ERROR: *** The above files still have references to the build directory.
> ERROR:     This is possibly an error that should be fixed by unwrapping
> ERROR:     the files or adding missing tools to the package makefile!
> *** Error code 1

This patch fixes it for me:
> richard@omnis:/home/richard/src/pkgsrc/sysutils/dbus$ git diff .
> diff --git a/sysutils/dbus/Makefile b/sysutils/dbus/Makefile
> index 337154a..92c5db4 100644
> --- a/sysutils/dbus/Makefile
> +++ b/sysutils/dbus/Makefile
> @@ -35,11 +35,9 @@ CONFIGURE_ARGS+=     --localstatedir=${VARBASE:Q}
>  
>  CONFIGURE_ARGS_GROUPS= enable disable with without
>  
> -.if ${OPSYS} == "Darwin"
>  # Prevent the configure script from picking up a per-user tmp
>  # directory. See the commit message on revision 1.35
>  CONFIGURE_ARGS+=       --with-session-socket-dir=/tmp
> -.endif
>  
>  CONFIGURE_ARGS+=       --without-init-scripts
>  CONFIGURE_ARGS+=       --disable-ansi

as justified by the configure script:
> #### Find socket directories
> if ! test -z "$TMPDIR" ; then
>    DEFAULT_SOCKET_DIR=$TMPDIR
> elif ! test -z "$TEMP" ; then
>    DEFAULT_SOCKET_DIR=$TEMP
> elif ! test -z "$TMP" ; then
>    DEFAULT_SOCKET_DIR=$TMP
> else
>    DEFAULT_SOCKET_DIR=/tmp
> fi

That is to say, the previous default.

Okay to commit both this dbus patch and the one for ncurses?

-- 
Richard PALO