tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wip/tme ready for review



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 14.07.2015 05:22, phabrics%phabrics.com@localhost wrote:
> After several more months of development & testing, I believe 
> wip/tme is now good enough to release to pkgsrc.  In particular, 
> new in this release are true multithreading using pthreads, as
> well as the other features added as originally detailed in [1]. In 
> addition, I have been in touch with the original upstream
> developer who has given his blessing to the updates added for
> importing. More details at [2].
> 

Impressive work.

My comments:
- - You use DESCR to say about the upcoming release ("New in this
release..."). From my experience DESCR can quickly get out of sync
with reality and it's better to note there just general info what the
package does.
- - Do we need this MESSAGE?
- - Version 0.10beta_6 - can we make it saner? Alphanumerical versions
tend to introduce issues with maintaining upgrades and comparing
version. Do you know whether 0.10 > 0.10beta_6 for pkgsrc? For RPM and
pkg-config it's false.
- - Do we need this CONFLICTS?
- - Lines 27-55 adding -W* and -f*, can you put these rules inside your
package? This shouldn't be maintained from pkgsrc.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVpjYIAAoJEEuzCOmwLnZsbQoP/A5oERx4zFfhSpWyU++w5kcU
jJ2zwPLnNVcAbnTENyHyqVOCow8cTejKIqWN805R3RQ5264xOhbd/7FnmQDD8ZYE
Yf4heBsoUXi0C1q0PbnXMPatOVuchd1l/RIMLUAE5Y+7ijamGqSHdy7YGnLpT0kr
EJ+W5L5DsabENRfhX+5y6BnDB3cQ0yK8XRqV3AQUFcmKfRvKA2Z4PG35m9jubsKz
z7Yz1ZGAf+r2e3h60OLMCkk2+RMaDeoWv7xAwvv47H2WJF7gif7ApPlyX3oevJzS
uvSfi8ULi2UTPd+aCAZejfRpeyRLMlsQYEjgQvFqm/aH5jDd/FzlHayCyONiqyj2
lfub6Br3iHvjhKm2DoCO7OSnn+HiU7g4t25IusPYd2DVvfwWVQKs0jSwS0z3Qju0
erSDDu3Hy6ttedCxVw1jHMT/yD0O6R3tPrEDvXaP1oME8MeDD3rNlRIrT+nvxNdW
rw3kkWWDg8wp1C1xapBSDH4i2M7zFptiKBK7QOKJHkbrcu9Ec7l9RzdVHAE9PaOT
XhGysBYkW7BBCKnlvh0ytdcKfxLDN2mB+MMjuA7fSHDPmiYAXc1dg+NSCfXSRsPx
ZvdFMZ7RHYBtP91tkaCmqmCWoMVbSojvMpRFwrCeTey8Pci19YU4PXPNBcc9ghiC
7aCBKGC7GjSFAaiU0qak
=qmHq
-----END PGP SIGNATURE-----


Home | Main Index | Thread Index | Old Index