Re: thunderbird-enigmail

[Kamil Rytarowski <n54%gmx.com@localhost>]

On 04.06.2015 17:34, Ryo ONODERA wrote:
> From: Kamil Rytarowski <n54%gmx.com@localhost>, Date: Thu, 04 Jun 2015 15:10:43 +0000
> 
>> On 04.06.2015 14:57, Ryo ONODERA wrote:
>>> Is your package compatible with www/seamonkey?
>>>
>>
>> At the moment no, but it shouldn't be too hard to add support for it.
>>
>> https://www.enigmail.net/download/source.php
>>
>> Likely just custom PKGNAME and do-install. I'm going to do it and create
>> wip/seamonkey-enigmail.
> 
> If only PKGNAME and do-install are for thunderbird.
> I think single enigmail package can provide enigmail extension to
> thunderbird and seamonkey.
> 
> How about the following? (not tested, it is concept)
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc-wip/wip/thunderbird-enigmail/Makefile,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile
> --- Makefile	4 Jun 2015 15:40:29 -0000	1.5
> +++ Makefile	4 Jun 2015 17:32:47 -0000
> @@ -10,4 +10,5 @@
>  DEPENDS+=		thunderbird>=31:../../mail/thunderbird
>  
>  # Path used during the install stage
> -XPIDIR=		${PREFIX}/lib/thunderbird/extensions
> +TBXPIDIR=		${PREFIX}/lib/thunderbird/extensions
> +SMXPIDIR=		${PREFIX}/lib/semonkey/extensions
> Index: Makefile.common
> ===================================================================
> RCS file: /cvsroot/pkgsrc-wip/wip/thunderbird-enigmail/Makefile.common,v
> retrieving revision 1.3
> diff -u -r1.3 Makefile.common
> --- Makefile.common	4 Jun 2015 16:17:49 -0000	1.3
> +++ Makefile.common	4 Jun 2015 17:32:47 -0000
> @@ -44,8 +44,11 @@
>  do-install:
>  	${RUN} EMID=`${SED} -n '/.*<em:id>\\(.*\\)<\\/em:id>.*/{s//\\1/p;q}' \
>  		${WRKSRC}/package/install.rdf` && \
> -		${INSTALL_DATA_DIR} ${DESTDIR}${XPIDIR}/"$$EMID" && \
> -		unzip -d ${DESTDIR}${XPIDIR}/"$$EMID" \
> +		${INSTALL_DATA_DIR} ${DESTDIR}${TBXPIDIR}/"$$EMID" && \
> +		${INSTALL_DATA_DIR} ${DESTDIR}${SMXPIDIR}/"$$EMID" && \
> +		unzip -d ${DESTDIR}${TBXPIDIR}/"$$EMID" \
> +		${XPIFILE} && \
> +		unzip -d ${DESTDIR}${SMXPIDIR}/"$$EMID" \
>  		${XPIFILE}
>  
>  .include "../../lang/python/application.mk"
> 

It doesn't like like the best design. There should be relation between a
tool and extension 1:1, not N:1. One tool and its extensions, another
tool and its extensions.

Having it many tools and one the same extension produces problems due to
asymmetry -- like API change in seamonkey can effect thunderbird
compatiblity -- having it separate will ensure flawless maintaining all
these problems.

Having one entry less in the pkg database is not worth it.