pkgtools/osabi is useless

[Aleksey Cheusov <cheusov%tut.by@localhost>]

Hi. I'd like to apply the following patch in order to avoid package
installation breakages caused by pkgtools/osabi package.

Why osabi is bad:
- Our official packages for NetBSD-6.1 are linked to 6.0 binaries.
  As a result binary installation fails on 6.1 due to osabi-NetBSD.
- osabi should be system-dependent, but currently it is not.
  Difference in kernel versions on Linux, for example, doesn't play
  too big role.
- It is a half-measure. There are too many things to check in order to
  garantee ABI compatibility, e.g. libc version on Linux. Checks for
  kernel version don't solve anything.

Personally, I whould prefer to completely remove osabi package, but the
following patch adds new variable IGNORE_OSABI to pkg_install.conf and
osabi package checks whether this varuable is "yes". So, sysadmins is
able to disable this check.

Objections?




Index: pkg_install/files/lib/pkg_install.conf.5.in
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/lib/pkg_install.conf.5.in,v
retrieving revision 1.17
diff -u -r1.17 pkg_install.conf.5.in
--- pkg_install/files/lib/pkg_install.conf.5.in	17 Dec 2012 04:34:02 -0000	1.17
+++ pkg_install/files/lib/pkg_install.conf.5.in	26 Oct 2014 14:19:42 -0000
@@ -146,6 +146,8 @@
 .Ev FTP_PROXY
 and
 .Ev HTTP_PROXY .
+.It Dv IGNORE_OSABI
+If "yes", osabi package does not check OS version.
 .It Dv IGNORE_URL
 One line per advisory which should be ignored when running
 .Dl Ic pkg_admin audit
Index: osabi/INSTALL
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/osabi/INSTALL,v
retrieving revision 1.3
diff -u -r1.3 INSTALL
--- osabi/INSTALL	23 Feb 2013 05:47:59 -0000	1.3
+++ osabi/INSTALL	26 Oct 2014 14:19:42 -0000
@@ -1,8 +1,14 @@
 # $NetBSD: INSTALL,v 1.3 2013/02/23 05:47:59 obache Exp $
 
 UNAME="@UNAME@"
+PKG_ADMIN="@PKG_ADMIN@"
+
 case ${STAGE} in
 PRE-INSTALL)
+	if test yes = "$($PKG_ADMIN config-var IGNORE_OSABI)"; then
+		exit 0
+	fi
+
 	OS_VERSION=`${UNAME} -r`
 	PKG_VERSION="${PKGNAME##*-}"
 	case `${UNAME} -s` in
Index: osabi/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/osabi/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- osabi/Makefile	3 Mar 2014 03:30:53 -0000	1.2
+++ osabi/Makefile	26 Oct 2014 14:19:42 -0000
@@ -9,6 +9,6 @@
 COMMENT=	Operating System version dummy-package
 
 META_PACKAGE=	yes
-FILES_SUBST+=	UNAME=${UNAME:Q}
+FILES_SUBST+=	UNAME=${UNAME:Q} PKG_ADMIN=${PKG_ADMIN:Q}
 
 .include "../../mk/bsd.pkg.mk"

-- 
Best regards, Aleksey Cheusov.