Re: Fix build version RCS id

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2014-10-07 at 11:36 BST, Joerg Sonnenberger wrote:

> On Tue, Oct 07, 2014 at 10:40:07AM +0100, Jonathan Perkin wrote:
>
> > The proposed fix to mk/pkgformat/pkg/metadata.mk is to ensure RCS
> > ids have the final "$", i.e.:
> 
> Not sure how much more reliable that is. I would go the other way
> and teach pkgdiff about it.

Problem is not everyone uses pkgdiff, but yes I'll do that anyway.

> >   $ git grep '$NetBSD: [^$]*$'
> >   devel/bmkdep/patches/patch-mkdep.c:@@ -52,7 +52,6 @@ __RCSID("$NetBSD: mkdep.c,v 1.43 2013/03
> >   filesystems/fs-utils/patches/patch-lib_getbsize.c:@@ -46,10 +46,6 @@ __RCSID("$NetBSD: getbsize.c,v 1.2 2009/
> >   security/heimdal/patches/patch-lib_libedit_src_unvis.c:@@ -46,9 +46,11 @@ __RCSID("$NetBSD: unvis.c,v 1.32 2010/11
> >   security/heimdal/patches/patch-lib_libedit_src_vis.c:@@ -67,6 +67,7 @@ __RCSID("$NetBSD: vis.c,v 1.41 2009/11/2
> 
> The last two should already be fixed.

Right, sorry, that was on a 2014Q2 branch.  The other two still stand.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com