tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Optimising _check-wrkref



* On 2014-09-02 at 14:32 BST, Jonathan Perkin wrote:

> The current implementation of _check-wrkref iterates over a list of
> directories and runs grep for each of them against every file listed
> in a package, at least when PKG_DEVELOPER is set.
> 
> This can be pretty slow, and I'd like to change it so we use a single
> egrep and a regexp instead.  A diff to implement that is here:
> 
>   http://us-east.manta.joyent.com/pkgsrc/public/patches/check-wrkref-opt.diff

Joerg suggested using the :ts| operator instead, which results in this
much simpler diff:

  http://us-east.manta.joyent.com/pkgsrc/public/patches/check-wrkref-opt-2.diff

Same performance improvement and functionality.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com


Home | Main Index | Thread Index | Old Index