Re: lang/php{54,55} and www/apache24 does not work without ZTS support

[Filip Hajny <filip%joyent.com@localhost>]

26. 3. 2014 v 5:29, Takahiro Kambe <taca%back-street.net@localhost>:

> In message 
> <CAHKF-AtLKMZmk_1k-s2C5S1FU7Xmkt8sBin+vCt8-YaZL1VRNg%mail.gmail.com@localhost>
>       on Tue, 25 Mar 2014 21:59:55 -0400,
>       matthew sporleder <msporleder%gmail.com@localhost> wrote:
>>> Index: lang/php54/Makefile.php
>>> ===================================================================
>>> RCS file: /cvsroot/pkgsrc/lang/php54/Makefile.php,v
>>> retrieving revision 1.6
>>> diff -u -u -r1.6 Makefile.php
>>> --- lang/php54/Makefile.php     21 Jul 2013 17:29:47 -0000      1.6
>>> +++ lang/php54/Makefile.php     25 Mar 2014 16:26:46 -0000
>>> @@ -72,7 +72,9 @@
>>> CONFIGURE_ARGS+=       --without-openssl
>>> .endif
>>> 
>>> -.if !empty(PKG_OPTIONS:Mmaintainer-zts)
>>> +.if empty(PKG_OPTIONS:Mmaintainer-zts)
>>> +CONFIGURE_ARGS+=       --disable-maintainer-zts
>>> +.else
>>> CONFIGURE_ARGS+=       --enable-maintainer-zts
>>> .endif
> I have expected to --disable-maintainer-zts disable "-DZTS" in CFLAGS,
> but sadly configure script dosen't honor it and it is enabled in
> www/ap-php depending on version of Apache.  :-(
> 
>> This disabled zts by default, right?
> Yes.  And if it is really required, maintainer-zts should be enabled
> whole PHP packages by some method.

As of now, this is still unfixed, and it went into 2014Q1. I intend to fix this 
by disabling the part in PHP’s configure that calls onto `httpd -V` to see if a 
threaded MPM is select - this is what really bakes ZTS into www/ap-php 
regardless of whether you pass --enable-maintainer-zts or not. That way 
hopefully we should have consistent PHP stack again, that’s entirely controlled 
by the zfs-maintainer option.

-F