tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: remove "(un)registering info file"?



On 16 January 2014 14:25, Thomas Klausner <wiz%netbsd.org@localhost> wrote:
> On Thu, Jan 16, 2014 at 02:21:49PM +0000, David Brownlee wrote:
>> > I don't see a point in these messages generated during pkg_add:
>>
>> Feels like something that should be shown under a verbose switch option...
>> (but no objections to them going away from the default output either way)
>
> Hm, I looked a bit deeper.
> The messages come from scripts from the pkginstall framework, which already
> have an option to be verbose or not. However:
>
> .if defined(PKG_DEVELOPER) && ${PKG_DEVELOPER} != "no"
> PKGINSTALL_VERBOSE?=    all
> .else
> PKGINSTALL_VERBOSE?=    # empty
> .endif
> .if !empty(PKGINSTALL_VERBOSE:Mall) || !empty(PKGINSTALL_VERBOSE:Mfonts)
> FILES_SUBST+=           FONTS_VERBOSE=yes
> .else
> FILES_SUBST+=           FONTS_VERBOSE=no
> .endif
> .if !empty(PKGINSTALL_VERBOSE:Mall) || !empty(PKGINSTALL_VERBOSE:Minfo-files)
> FILES_SUBST+=           INFO_FILES_VERBOSE=yes
> .else
> FILES_SUBST+=           INFO_FILES_VERBOSE=no
> .endif
>
> The default is verbose if PKG_DEVELOPER is set, and since we suggest
> this for all bulk builders, it's default in most binary packages.
>
> Ideas?

In an ideal world that verbose decision would be deferred to the install tools.
pkg_add already has a -v, maybe work towards passing that down?


Home | Main Index | Thread Index | Old Index