Re: Build failure of editors/nvi on SunOS (SmartOS and OmniOS)

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

From: Jonathan Perkin <jperkin%joyent.com@localhost>, Date: Fri, 20 Sep 2013 
15:06:49 +0100

> * On 2013-09-20 at 15:01 BST, Jonathan Perkin wrote:
> 
>> * On 2013-09-20 at 14:40 BST, Ryo ONODERA wrote:
>> 
>> > I have built editors/nvi and gotten the following error.
>> > This error message is recored on OmniOS-b281e50, and on SmartOS
>> > joyent_20130322T181205Z, I have gotten same error.
>> > 
>> > But recent bulk build on SmartOS by joyent does not report build
>> > failure of editors/nvi.
>> > 
>> > What is difference between bulk build and manual build?
>> 
>> The difference is we set PREFER_PKGSRC=yes, and in this case that
>> means the native curses is used instead of ncurses.
>> 
>> > How to fix this build failure?
>> 
>> The problem is that 'isblank' is being redefined somewhere, but I
>> haven't found where yet.  Looking at gcc -E output of the compile line
>> we get:
>> 
>>   # 59 "/usr/include/iso/ctype_c99.h" 3 4
>>   extern int ((int) == ' ' || (int) == '\t');
>> 
>> hence the failure.
> 
> Oh, it's nvi itself:
> 
>   nvi-1.81.6/common/key.h:
>   #ifndef isblank
>   #define isblank(ch)     ((ch) == ' ' || (ch) == '\t')
>   #endif
> 
> I'll leave you to fix nvi ;)

Thank you very much.
I will fix nvi for SunOS.

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3