Re: pkg_install patch to support sysutils/etckeeper

[Thomas Klausner <tk%giga.or.at@localhost>]

On Wed, May 29, 2013 at 10:58:02PM +1200, Steven Drake wrote:
> On Mon, 27 May 2013, Thomas Klausner wrote:
> 
> > The infrastructure already supports the same idea, but for the INSTALL
> > and DEINSTALL scripts that you can add to packages. See
> > files/add/perform.c:run_install_script() which is called in pkg_do()
> > before and after extract_files().
> 
> I am aware of that :)

Ok, good :)

> > I guess this is not exactly the right place for what we need for
> > etckeeper?
> 
> Correct, what basically need to be automated is
> 
> $ etckeeper pre-install
> $ pkg_add a-package another-package ...
> $ etckeeper post-install
> 
> Whats important is that the pre-install command is run before any package
> is installed and the post-install command run after all packages have been 
> installed.  Using a shell script wrapper around pkg_add would work fine.

So do I understand correctly that it wouldn't fit well in the design
concept of etckeeper to be called after every pkg_add/pkg_delete?

> > And a minor thing: When you bump the version in version.h:
> [...]
> > the version in the Makefile automatically increases.
> 
> I also know that.

Oops, sorry, I read the diff wrong.
 Thomas