PKG_DEVELOPER=YES and patching failure message

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

(1)
In pkgsrc/mk/defaults/mk.conf, PKGSRC_SHOW_PATCH_ERRORMSG is defined,
but it is not used in pkgsrc/mk.

Can I remove the following lines?

.if defined(PKG_DEVELOPER) && ${PKG_DEVELOPER} != "no"
PKGSRC_SHOW_PATCH_ERRORMSG?=no
.else
PKGSRC_SHOW_PATCH_ERRORMSG?=yes
.endif
# Print a potentially helpful error message when the "patch" stage fails
# Possible: "yes", not "yes"
# Default: "no" if PKG_DEVELOPER is enabled, "yes" otherwise


(2)
If there is patches for nonexistent files, make patch generates
the following line only, even when PKG_DEVELOPER=yes is defined.

File to patch:


If PATCH_DEBUG is defined, I can get the following lines.

=> Verifying /usr/pkgsrc/local/gb1911-font.test/patches/patch-test
=> Applying pkgsrc patch /usr/pkgsrc/local/gb1911-font.test/patches/patch-test
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|$NetBSD$
|
|--- test.orig  2013-05-06 01:05:16.000000000 +0000
|+++ test
--------------------------
File to patch:


I feel, pkgsrc developers want to know which patch is failed.

I want to commit the following patch.
Are there any opinions?

Index: mk/defaults/mk.conf
===================================================================
RCS file: /cvsroot/pkgsrc/mk/defaults/mk.conf,v
retrieving revision 1.221
diff -u -r1.221 mk.conf
--- mk/defaults/mk.conf 6 Apr 2013 11:11:56 -0000       1.221
+++ mk/defaults/mk.conf 6 May 2013 01:56:26 -0000
@@ -71,6 +71,13 @@
 # Possible: defined, not defined
 # Default: not defined
 
+.if defined(PKG_DEVELOPER) && ${PKG_DEVELOPER} != "no"
+PATCH_DEBUG=
+.endif
+# Used to debug patches as they are applied
+# Possible: defined, not defined
+# Default: not defined
+
 PKG_COMPRESSION?=      gzip
 # Compression algorithm for binary packages.
 # Possible: gzip, bzip2, none


Thank you.

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3