Re: xentools41 paths

[eric%cirr.com@localhost (Eric Schnoebelen)]

Ignatios Souvatzis writes:
- On Thu, Mar 14, 2013 at 09:58:29PM +0100, Ignatios Souvatzis wrote:
- > Here's what's missing from Aarons patch set:
- > 
- > a) config paths, device paths adapted
- > b) Trimming what's read out ... but instead of Aaron's adopted
- >    Rosetta code, using a new String class function.
- > 
- > Hm... I wonder whether xenstored_proc_kva and xenstored_proc_port
- > should be patched per-OS. What does cxenstored do in our pkg?
- 
- Updated to remove fixed pathes (using SUBST & friends).

I think you missed one path..

- diff -N patches/patch-ocaml_xenstored_define.ml
- --- /dev/null 1 Jan 1970 00:00:00 -0000
- +++ patches/patch-ocaml_xenstored_define.ml   15 Mar 2013 08:57:10 -0000
- @@ -0,0 +1,20 @@
- +$NetBSD$
- +
- +--- ocaml/xenstored/define.ml.orig   2012-11-24 07:27:21.000000000 +0000
- ++++ ocaml/xenstored/define.ml        2012-11-24 07:33:59.000000000 +0000
- +@@ -17,13 +17,13 @@
- + let xenstored_major = 1
- + let xenstored_minor = 0
- + 
- +-let xenstored_proc_kva = "/proc/xen/xsd_kva"
- ++let xenstored_proc_kva = "@PROCDEV@/xsd_kva"
- + let xenstored_proc_port = "/proc/xen/xsd_port"

Since NetBSD doesn't have /proc/xen, /proc/xen/xsd_port is
meaningless/silly.

I suspect it should be /kern/xen/xsd_port.  Not sure how you
want to subst that in, as @PROCDEV@ won't be the correct prefix.

Perhaps mask both into full paths, and set as appropriate in the
SUBST clauses of the Makefile?

- + 
- + let xs_daemon_socket = "/var/run/xenstored/socket"
- + let xs_daemon_socket_ro = "/var/run/xenstored/socket_ro"
- + 
- +-let default_config_dir = "/etc/xensource"
- ++let default_config_dir = "@XENDCONFDIR@"
- + 
- + let maxwatch = ref (50)
- + let maxtransaction = ref (20)


--
Eric Schnoebelen                eric%cirr.com@localhost         
http://www.cirr.com
        "I used to think I was indecisive, but now I'm not so sure."