tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: disabling unsupported options

On Wed, Jan 16, 2013 at 07:05:07AM +0000, Taylor R Campbell wrote:
> In my mk.conf I turn off various options with PKG_OPTIONS.pkg+= -foo.
> If a package uses the options variable PKG_OPTIONS.pkg, though, and
> does not support the option `foo', this makes it fail to build, which
> seems awfully silly.
> For example, I have PKG_OPTIONS.mplayer+= -mplayer-real to disable
> proprietary codecs -- but since that option is supported only on i386,
> powerpc, and alpha, mplayer fails to build on amd64 with that setting,
> even though I'm turning it off.
> Any objections to the following patch to stop failing packages because
> the user disabled options that aren't supported?

IIRC, the point of the check was to help you avoid using obsolete or
typoed variables.

Perhaps making the build fail is too much, but I think at least a
warning is in order.

Home | Main Index | Thread Index | Old Index