tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

bug in pkg-build-options.mk



I think pkg-build-options.mk has a minor bug; it's iterating over "b
in ${pkgbase}" but then still uses ${pkgbase} in one place inside the
loop.

See attached diff for a fix. Did I overlook anything?
 Thomas
Index: pkg-build-options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/pkg-build-options.mk,v
retrieving revision 1.8
diff -u -U 4 -r1.8 pkg-build-options.mk
--- pkg-build-options.mk        20 Mar 2009 19:25:01 -0000      1.8
+++ pkg-build-options.mk        17 Dec 2012 12:53:14 -0000
@@ -42,9 +42,9 @@
 .  for b in ${pkgbase}
 .    if !defined(PKG_BUILD_OPTIONS.${b})
 PKG_BUILD_OPTIONS.${b} != \
        echo ""; \
-       ${PKG_INFO} -Q PKG_OPTIONS ${pkgbase} 2>/dev/null \
+       ${PKG_INFO} -Q PKG_OPTIONS ${b} 2>/dev/null \
        || { cd ${BUILDLINK_PKGSRCDIR.${b}} \
             && ${MAKE} ${MAKEFLAGS} show-var VARNAME=PKG_OPTIONS; }
 
 MAKEFLAGS+=    PKG_BUILD_OPTIONS.${b}=${PKG_BUILD_OPTIONS.${b}:Q}


Home | Main Index | Thread Index | Old Index