tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/net/xorp

  Module Name:  pkgsrc
  Committed By: joerg
  Date:         Tue Jul  3 17:36:10 UTC 2012

  Modified Files:
          pkgsrc/net/xorp: Makefile distinfo
          pkgsrc/net/xorp/patches: patch-libxorp_xorp.h
  Added Files:
          [24 more patch files omitted]

  Fix a number of issues found by clang:
  - missing this references to ensure template functions are found
  - using == as assignment
  - unused functions in lex sources
  - adding integers to strings instead of formatting them
  - class vs struct mismatches

Did you file these in a xorp tracker?  I'm concerned that without a
concerted attempt to get fixes upstream it will just be harder to update
packages, with the result being that packages like this never see
updates.  (I looked at one file and didn't see a reference to an
upstream tracker.)

Were these errors, or warnings (or warnings turned into errors)?

I'm not arguing that the code wasn't wrong.  But I'm wondering if it's
really a good idea over the long term to make such large changes in
pkgsrc vs working directly with upstream.

Attachment: pgp4bBy7_CB0H.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index