Re: Problems with "freetype2" package under Mac OS X

["OBATA Akio" <obache%netbsd.org@localhost>]

Hi,

On Wed, 28 Mar 2012 15:28:39 +0900, Matthias Scheler 
<tron%netbsd.org@localhost> wrote:

> tron@excalibur:/usr/pkgsrc/net/wireshark>bmake VARNAME=USE_BUILTIN.freetype2 
> show-var
> yes
> tron@excalibur:/usr/pkgsrc/net/wireshark>bmake VARNAME=BUILTIN_PKG.freetype2 
> show-var
> freetype2-2.3.9
>
> Before this change "pkgsrc" would not use the system provided "freetype2".

I feel that it is "FIXED" behavior.
Previously, builtin freetype2 was also check with `imake' in addition to 
existence
of header file, but recent Mac OS does not have buitin `imake', so it always 
failed,
i.e, builtin freetype2 was never used.

> Looking at the required version numbers ...
>
> BUILDLINK_API_DEPENDS.freetype2+=       freetype2>=2.1.8
> BUILDLINK_ABI_DEPENDS.freetype2+=       freetype2>=2.4.7nb2
>
> ... it should still not do that. Looking at "freetype2/builtin.mk" ...
>
> .      for _dep_ in ${BUILDLINK_API_DEPENDS.freetype2}
> .        if !empty(USE_BUILTIN.freetype2:M[yY][eE][sS])
> USE_BUILTIN.freetype2!=                                                 \
>         if ${PKG_ADMIN} pmatch ${_dep_:Q} ${BUILTIN_PKG.freetype2:Q}; then \
>                 ${ECHO} yes;                                            \
>         else                                                            \
>                 ${ECHO} no;                                             \
>         fi
> .        endif
> .      endfor
>
> ... I wonder if this check is wrong. Should it check both "API_DEPENDS"
> and "ABI_DEPENDS"? Or are the version numbers just not sensible?

No, only API_DEPENDS should be checked.

--
OBATA Akio / obache%NetBSD.org@localhost