tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Sanitising make environment in pkgsrc

On Wed, 17 Aug 2011 00:05:04 +0900, David Brownlee <> 

On 16 August 2011 15:10, Martin S. Weber <> wrote:
On Tue, Aug 16, 2011 at 03:46:15PM +0200, Joerg Sonnenberger wrote:
On Tue, Aug 16, 2011 at 01:24:43PM +0100, David Brownlee wrote:
> The attached patch defines CLEANENV as "${SETENV} -i" then uses it
> instead of SETENV when defining MAKE_ENV for pkgsrc sub makes.
> Its been tested in NetBSD and Linux (RHEL) including bootstrap.
> Does anyone have any objections/comments?

Yes, I object without proper reasoning.

Understandable. The topic has been brought up in may already btw, see
the thread here:

Thanks Martin - I really should have included a reference to that in
my last email.

Joerg, does that cover your question?

For ENV=/some/where and setting PATH in the file issue,
I feel that it should be fixed instead.
PATH should be set only for interactive mode, or various other shell scripts
(not pkgsrc) also may not work as expected because of same reasons.

OBATA Akio /

Home | Main Index | Thread Index | Old Index