Re: xf86-video-intel vs pthreads

[Sean Boudreau <seanb%qnx.com@localhost>]

On Fri, Jun 03, 2011 at 09:58:56AM -0400, Christos Zoulas wrote:
> In article <20110603131540.GF745511%qnx.com@localhost>,
> Sean Boudreau  <seanb%qnx.com@localhost> wrote:
> >On Fri, Jun 03, 2011 at 08:54:13AM -0400, OBATA Akio wrote:
> >> On Fri, 03 Jun 2011 21:43:53 +0900, Sean Boudreau <seanb%qnx.com@localhost>
> wrote:
> >> 
> >> > My first thought was only $(PTHREAD_LIBS), but why is
> >> > PTHREAD_LIBS empty on NetBSD?
> >> 
> >> Because with -pthread linker flag, pthread library will be linked on
> >> NetBSD,
> >> so no need to specify pthread library with -lpthread.
> >
> >Would it hurt though?  Here they're really listing libs,
> >not linker flags.
> 
> It is wrong from a portability perspective. Specifying -pthread in the
> compiler
> line is supposed to take care of all compilation and linking flags.
> Adding
> extra's might break things.
> 
> christos
> 

So this then?

Thanks,

-seanb

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xf86-video-intel/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- Makefile    19 Jan 2011 18:12:21 -0000      1.24
+++ Makefile    3 Jun 2011 18:31:33 -0000
@@ -27,4 +27,5 @@
 .include "../../x11/libXvMC/buildlink3.mk"
 .include "../../x11/libdrm/buildlink3.mk"
 .include "../../x11/xineramaproto/buildlink3.mk"
+.include "../../mk/pthread.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xf86-video-intel/distinfo,v
retrieving revision 1.18
diff -u -r1.18 distinfo
--- distinfo    10 Aug 2009 06:17:21 -0000      1.18
+++ distinfo    3 Jun 2011 18:31:33 -0000
@@ -3,5 +3,6 @@
 SHA1 (xf86-video-intel-2.7.1.tar.bz2) = 
f863ee65b4b7779077af9f819b07033264284628
 RMD160 (xf86-video-intel-2.7.1.tar.bz2) = 
25208fe03f0fe849974a703f4a81e734e67cad18
 Size (xf86-video-intel-2.7.1.tar.bz2) = 780625 bytes
+SHA1 (patch-aa) = 7804346b3442c1435bd9292e9c2d411854dbd4e2
 SHA1 (patch-ad) = 9b001f43451daa8a68acb5059f993bcc1f3588f8
 SHA1 (patch-ag) = 68f282d59e03c74727de4577eb48297d9022e542
Index: patches/patch-aa
===================================================================
RCS file: patches/patch-aa
diff -N patches/patch-aa
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-aa    3 Jun 2011 18:31:33 -0000
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- src/xvmc/Makefile.in.orig  2009-05-13 00:14:43.000000000 +0000
++++ src/xvmc/Makefile.in
+@@ -265,7 +265,7 @@ libIntelXvMC_la_CFLAGS = @XORG_CFLAGS@ @
+       @XVMCLIB_CFLAGS@ -I$(top_srcdir)/src -DTRUE=1 -DFALSE=0
+ 
+ libIntelXvMC_la_LDFLAGS = -version-number 1:0:0
+-libIntelXvMC_la_LIBADD = @DRI_LIBS@ @DRM_LIBS@ @XVMCLIB_LIBS@ @XEXT_LIBS@ 
-lpthread
++libIntelXvMC_la_LIBADD = @DRI_LIBS@ @DRM_LIBS@ @XVMCLIB_LIBS@ @XEXT_LIBS@ 
$(PTHREAD_LDFLAGS) $(PTHREAD_LIBS)
+ INTEL_G4A = \
+         dual_prime_igd.g4a              \
+         field_backward_igd.g4a          \