Re: Making DESTDIR support mandatory

[Thomas Klausner <wiz%NetBSD.org@localhost>]

Hi!

Since the branch is cut, perhaps we can progress on the destdir issue.

Btw, thanks for the people who converted another few packages to
destdir support!

I suggest the attached patch -- this makes packages not build if they
are not using destdir support, as incentive for people interested in
them to fix them.

We can then decide before the next branch if we want to revert the
patch, just leave it in (my suggestion), or go further and actually
remove the BROKEN packages.

Comments?
 Thomas

Index: bsd.prefs.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.prefs.mk,v
retrieving revision 1.313
diff -u -r1.313 bsd.prefs.mk
--- bsd.prefs.mk        31 Jan 2011 08:18:44 -0000      1.313
+++ bsd.prefs.mk        6 Apr 2011 13:40:09 -0000
@@ -445,8 +445,8 @@
 PKG_FAIL_REASON+=      "PKG_DESTDIR_SUPPORT must be \`\`destdir'' or 
\`\`user-destdir''."
 .endif
 
-.if defined(PKG_DEVELOPER) && ${PKG_DEVELOPER} != "no" && 
empty(PKG_DESTDIR_SUPPORT)
-WARNINGS+=     "[bsd.prefs.mk] The package ${PKGNAME} is missing DESTDIR 
support."
+.if empty(PKG_DESTDIR_SUPPORT)
+BROKEN=        "[bsd.prefs.mk] The package ${PKGNAME} is missing DESTDIR 
support."
 .endif
 
 # When using staged installation, everything gets installed into