Re: Changing the OS_VERSION on AIX (Was Re: pkg/44421: pkgtools/osabi from pkgsrc-2010Q4 fails to install on aix 5.3)

[Ignatios Souvatzis <is%netbsd.org@localhost>]

On Fri, Jan 21, 2011 at 07:05:47PM +1300, Steven Drake wrote:
> On Thu, 20 Jan 2011, jxraynor%gmail.com@localhost wrote:
> 
> > >Number:         44421
> > >Synopsis:       pkgtools/osabi from pkgsrc-2010Q4 fails to install on aix 
> > >5.3
>  
> > pkgsrc reports the OS_VERSION as 5.3.0.0.  From a brief discussion on 
> > pkgsrc-users, pkgsrc should report OS_VERSION as 5.3.
> 
> Discussion was with me.
> 
> > >Fix:
> > The problem is in pkgsrc/mk/bsd.prefs.mk.  Backslashes are not needed to do 
> > the regex grouping, and their presence interferes with it.  This prevents 
> > "5.3.0.0" from being transformed into "5.3" as intended.  The following 
> > patch fixes the problem:
> > 
> > 
> > --- bsd.prefs.mk.orig   2011-01-19 12:42:26.000000000 -0600
> > +++ bsd.prefs.mk        2011-01-19 12:42:50.000000000 -0600
> > @@ -115,7 +115,7 @@
> >  .  else
> >  _OS_VERSION!=          echo `${UNAME} -v`.`${UNAME} -r`
> >  .  endif
> > -OS_VERSION=            ${_OS_VERSION:C/\([0-9]*\.[0-9]*\).*/\1/}
> > +OS_VERSION=            ${_OS_VERSION:C/([0-9]*\.[0-9]*).*/\1/}
> >  LOWER_OPSYS_VERSUFFIX= ${_OS_VERSION}
> >  LOWER_OPSYS?=          aix
> >  LOWER_VENDOR?=         ibm
> 
> Are the any objections to appling this patch?


looks good to me. 

        -is