Re: mail/evolution-data-server

[Sean Boudreau <seanb%qnx.com@localhost>]

On Fri, May 14, 2010 at 04:50:55PM -0400, Sean Boudreau wrote:
> 
> Hi:
> 
> I don't think mail/evolution-data-server/patches/patch-ak is
> behaving as intended.  The base Makefile is passing
> 
> CONFIGURE_ENV+=               PTHREAD_LIB="${PTHREAD_LDFLAGS} ${PTHREAD_LIBS}"
> 
> but the configure script is setting this to en empty string.
> With the patch as is the passed in lib is ignored but
> if pthread_create happens to be in libc (empty string as
> mentioned above), -lpthread is still set.  Here's what I
> think was intended.  This finds -lpthread in NetBSD where
> it wasn't before and nothing (libc) on QNX.
> 
> Regards,
> 
> -seanb


I see a variant of the previous diff was checked in.  What's
there now fixes NetBSD but it always adds -lpthread instead
of ${PTHTREAD_LIB}.  The attached is still needed on QNX
where ${PTHREAD_LIB} != -lpthread.

Regards,

-seanb

Index: evolution-data-server/patches/patch-ak
===================================================================
RCS file: /cvsroot/pkgsrc/mail/evolution-data-server/patches/patch-ak,v
retrieving revision 1.12
diff -r1.12 patch-ak
22a23,31
> @@ -22533,7 +22532,7 @@ fi
>  { $as_echo "$as_me:$LINENO: result: $ac_cv_lib_pthread_pthread_create" >&5
>  $as_echo "$ac_cv_lib_pthread_pthread_create" >&6; }
>  if test "x$ac_cv_lib_pthread_pthread_create" = x""yes; then
> -  PTHREAD_LIB="-lpthread"
> +  PTHREAD_LIB="${PTHREAD_LIB}"
>  else
>    { $as_echo "$as_me:$LINENO: checking for pthread_create in -lpthreads" >&5
>  $as_echo_n "checking for pthread_create in -lpthreads... " >&6; }