PR pkg/42515 points out that 'svnadmin create' fails because sqlite3 is
not compiled in thread-safe mode.
I have appended a potential patch to sqlite3 taken more or less from the
PR. I've tried it and subversion seems to work.
--with-readline-incs is removed because sqlite3's configure complains
bout it. It doesn't actually need to be part of this patch, but it
might as well get cleaned up.
Can anyone comment on how sqlite3 is supposed to be compiled, according
to sqlite3 people, and the consequences of having it compiled with
pthreads on programs that aren't expecting that? Can anyone foresee
adverse consequences of this.
This is too scary to commit during the freeze, so I'm curious about
opinions if this should be committed post-freeze.
Index: databases/sqlite3/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/databases/sqlite3/Makefile,v
retrieving revision 1.23
diff -u -p -r1.23 Makefile
--- databases/sqlite3/Makefile 16 Dec 2009 19:25:38 -0000 1.23
+++ databases/sqlite3/Makefile 31 Dec 2009 16:46:30 -0000
@@ -2,6 +2,7 @@
DISTNAME= sqlite-amalgamation-3.6.21
PKGNAME= ${DISTNAME:S/sqlite-amalgamation/sqlite3/}
+PKGREVISION= 1
CATEGORIES= databases
MASTER_SITES= http://www.hwaci.com/sw/sqlite/ \
http://www.sqlite.org/
@@ -21,7 +22,7 @@ WRKSRC= ${WRKDIR}/sqlite-${PKGVERSION_
PKGCONFIG_OVERRIDE+= sqlite3.pc.in
INSTALLATION_DIRS+= ${PKGMANDIR}/man1
-CONFIGURE_ARGS+= --with-readline-inc=
+CONFIGURE_ARGS+= --enable-threadsafe
# Uses dlopen and friends but doesn't use -ldl on Linux.
# See http://www.sqlite.org/cvstrac/tktview?tn=3555
@@ -33,4 +34,5 @@ post-install:
.include "../../devel/readline/buildlink3.mk"
.include "../../mk/dlopen.buildlink3.mk"
+.include "../../mk/pthread.buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
Attachment:
pgpRbfT2M5zFz.pgp
Description: PGP signature