tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: www/emacs-w3m still using ${_EMACS_VERSION_NOREV}



> Hi,

> www/emacs-w3m still using ${_EMACS_VERSION_NOREV}, but it seems gone away.
> It is used for path for icon directory,
> (for example, expected as share/emacs/22.3/etc/w3m with current editor/emacs).
> but now installed in share/emacs//etc/w3m.

> If ${_EMACS_VERSION_NOREV} is replaced with 
> ${_EMACS_VERSION_MAJOR}.${_EMACS_VERSION_MINOR},
> icons will be installed as expected.

> But the path really should contains emacs' version?
> If emacs is minor updated, directory name is changed, but depended pattern is 
> like a emacs>=22,
> so will be mismatch between emacs-w3m compiled with older emacs and newer 
> emacs.
> On the other hand, the path should not contains emacs' version?
> Yes, configure script accept option to specify icon directory,
> but it seems only affetct to installation, not to elisp...

Now (2008Q4) www/emacs-w3m fails to build on my system (netbsd-4).

http://mova.org/~cheusov/pub/pkgsrc-distbb/NetBSD/2008Q4/logs/20090111.1323/www_emacs-w3m_emacs-w3m-1.4.4nb1/stage_install.html

    => Checking file-check results for emacs-w3m-1.4.4nb1
    ERROR: ************************************************************
    ERROR: The following files are in /usr/pkg but not in the PLIST:
    ERROR:         /usr/pkg/share/emacs/etc/w3m/COPYING
    ERROR:         /usr/pkg/share/emacs/etc/w3m/ChangeLog
    ... tons of files here

How about replacing _EMACS_VERSION_NOVER with _EMACS_VERSION_MAJOR?

The following patch fixes the building failure and, I think, problems
mentioned by you too.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/emacs-w3m/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- Makefile    13 Oct 2008 08:07:02 -0000      1.24
+++ Makefile    12 Jan 2009 21:46:12 -0000
@@ -48,7 +48,7 @@
 
 INSTALL_TARGET.emacs=  install install-icons
 INSTALL_TARGET.xemacs= install-package
-ETCDIR.emacs=          share/emacs/${_EMACS_VERSION_NOREV}/etc/w3m
+ETCDIR.emacs=          share/emacs/${_EMACS_VERSION_MAJOR}/etc/w3m
 ETCDIR.xemacs=         lib/xemacs/site-packages/etc/w3m
 
 post-install:

-- 
Best regards, Aleksey Cheusov.


Home | Main Index | Thread Index | Old Index