Re: [joerg%netbsd.org@localhost: CVS commit: pkgsrc/devel/nbpatch]

[Yuji Yamano <yyamano%kt.rim.or.jp@localhost>]

Joerg Sonnenberger <joerg%britannica.bec.de@localhost> writes:

> I'd appreciate testing on all platforms to sort out the remaining
> modernisms in this code.

On Mac OS X 10.5.4, I got the following errors:

===> Building for libnbcompat-20080908
gcc -no-cpp-precomp -isystem /usr/include -I. -I.  -pipe -O2 -DHAVE_CONFIG_H -c 
bits.c
gcc -I. -I.  -pipe -O2 -L/usr/pkg/lib -o bits bits.o
./bits nbcompat/nbtypes.h
/usr/bin/awk -f nbcompat.awk nbcompat/config.h > nbcompat/nbconfig.h
gcc -no-cpp-precomp -isystem /usr/include -I. -I.  -pipe -O2 -DHAVE_CONFIG_H -c 
glob.c
In file included from ./nbcompat.h:55,
                 from __glob13.c:35,
                 from glob.c:12:
./nbcompat/grp.h:48: error: conflicting types for 'group_from_gid'
/usr/include/grp.h:110: error: previous declaration of 'group_from_gid' was here
In file included from ./nbcompat.h:57,
                 from __glob13.c:35,
                 from glob.c:12:
./nbcompat/pwd.h:48: error: conflicting types for 'user_from_uid'
/usr/include/pwd.h:142: error: previous declaration of 'user_from_uid' was here
*** Error code 1


I guess your change in pkgtools/libnbcompat/files/configure.ac rev.164 
breaks it. Mac OS X has group_from_gid(), but doesn't have gid_from_group().

Here is fragments of the config.log:

configure:11942: checking for gid_from_group
configure:11998: gcc -o conftest -pipe -O2 -no-cpp-precomp -isystem 
/usr/include -L/usr/pkg/lib conftest.c -lutil  >&5
Undefined symbols:
  "_gid_from_group", referenced from:
      _main in ccGZbVY5.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
configure:12005: $? = 1
configure: failed program was:
| /* confdefs.h.  */

[snip]

| int
| main ()
| {
| return gid_from_group ();
|   ;
|   return 0;
| }
configure:12027: result: no
configure:12049: checking for fts_open
configure:12105: gcc -o conftest -pipe -O2 -no-cpp-precomp -isystem 
/usr/include -L/usr/pkg/lib conftest.c -lutil  >&5

-- Yuji Yamano