Subject: Re: Gnome-panel patches for Joerg or jmmv or drochner
To: None <tech-pkg@netbsd.org>
From: Joerg Sonnenberger <joerg@britannica.bec.de>
List: tech-pkg
Date: 11/30/2007 18:45:55
On Fri, Nov 30, 2007 at 09:20:57AM -0800, walt wrote:
> --- gnome-panel/panel-util.c.orig	2007-11-30 08:49:03 -0800
> +++ gnome-panel/panel-util.c
> @@ -854,6 +854,10 @@ char *
>  panel_make_unique_desktop_path_from_name (const char *dir,
>  					  const char *name)
>  {
> +#ifdef NAME_MAX
> +#undef MAXNAMLEN
> +#define MAXNAMLEN NAME_MAX
> +#endif
>  	int   num = 1;
>  	char *path = NULL;
>  	char  filename[MAXNAMLEN];

Please make it the other way around, that's much easier to merge
upstream. E.g. code should use NAME_MAX and fallback to define it as
MAXNAMLEN.

Joerg