Subject: Re: Duplicate entries when showing dependance
To: None <firstname.lastname@example.org>
From: Arnaud Lacombe <email@example.com>
Date: 10/15/2007 23:39:57
Content-Type: text/plain; charset=ISO-8859-1
On 10/15/07, Klaus Heinz <firstname.lastname@example.org> wrote:
> Arnaud Lacombe wrote:
> > As it also happens with -current make(1) from march, I don't think it
> > has anything to do with recent change in it.
> > Should I PR this ?
> A known problem in mk/*. Fixing it was deemed to be too dangerous. I
> do not know whether this assessment is still valid.
ok, from my point of view, it seems pretty simple to fix. Here is
globally what happens to trigger the bug: in
mk/flavor/pkg/reduce-depends.awk, 'match_all' is initialized only if
'ge_depends' is not empty, which happens only if no regexp are
matched. So if a regexp is matched, 'ge_depends' will be empty, and
then th test on 'match_all', line 142, will be evaluated as true
('match_all' has not been set to 1 yet).
The following patch make things works better, at least for me. I tried
on a few packages and the output didn't change. BTW, net/nmapfe was
also affected by this problem.
Could this patch be considered as "deemed too dangerous" ?
Content-Type: application/octet-stream; name="duplicate_depends.diff"
Content-Disposition: attachment; filename="duplicate_depends.diff";