Subject: Re: CVS commit: pkgsrc/converters/libiconv
To: None <firstname.lastname@example.org>
From: Amitai Schlair <email@example.com>
Date: 06/09/2007 18:37:23
On Jun 9, 2007, at 6:28 PM, Joerg Sonnenberger wrote:
> On Sat, Jun 02, 2007 at 06:56:07AM +0000, Amitai Schlair wrote:
>> Don't require c99 in USE_LANGUAGES. libiconv builds fine with gcc
>> 2.95.4 on FreeBSD 4.11 without it; with it, pkgsrc wants gcc3-c,
>> which results in a circular dependency.
> Just because it works with GCC 2.95.4 doesn't mean that it doesn't use
> C99 features. Some of them were supported a long time with GCC as
> extensions. So I don't really like this kind of change...
I don't disagree, but we had definitely broken things unnecessarily
for that FreeBSD, and my educated guess (based on the CVS history)
was that this was a low-impact change for most of our platforms. If
it does break elsewhere as a result, then I'm certainly open to
solving it more properly.