Subject: creating pkg_summary after each bulk build
To: None <tech-pkg@NetBSD.org>
From: Hubert Feyrer <hubert@feyrer.de>
List: tech-pkg
Date: 03/17/2007 19:43:44
Right now we only create a pkg_summary file when uploading to the NetBSD 
FTP server. When someone else whants a pkg_summary file, they have to do 
things manually.

I'd suggest we change this to creating the pkg_summary after each bulk 
build, regardless if it's uploaded somewhere or not.

Why? Local pkgtools may want to make use of the file.

The patche below is intended to change this. I cannot test it though.
Any comments? Commit? Objections?


  - Hubert


Index: build
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bulk/build,v
retrieving revision 1.101
diff -u -r1.101 build
--- build	7 Mar 2007 23:32:49 -0000	1.101
+++ build	17 Mar 2007 18:40:59 -0000
@@ -128,6 +128,16 @@
  	done

  	#
+	# Create pkg_summary file
+	#
+	if [ "${MKSUMMARY-}" = "yes" -o "${MKSUMMARY-}" = "YES" ]; then
+		echo "upload> Creating summary file..."
+		(cd "${packages}/All" \
+			&& ls -t | grep '\.t[gb]z$' | while read n; do pkg_info -X "$n"; done) \
+		| ${gzip_cmd} > "${packages}"/All/pkg_summary.gz
+	fi
+
+	#
  	# Generate the post-build report.
  	#
  	echo "build> Generating the bulk build report..."
Index: build.conf-example
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bulk/build.conf-example,v
retrieving revision 1.37
diff -u -r1.37 build.conf-example
--- build.conf-example	6 Mar 2007 10:57:11 -0000	1.37
+++ build.conf-example	17 Mar 2007 18:40:59 -0000
@@ -91,7 +91,7 @@
  MKSUMS=yes

  # Whether or not to create the summary file.
-MKSUMMARY=no
+MKSUMMARY=yes

  # If you want to PGP sign the checksum files, set and correct.
  #SIGN_AS=username@NetBSD.org
Index: upload
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bulk/upload,v
retrieving revision 1.37
diff -u -r1.37 upload
--- upload	15 Dec 2006 13:15:06 -0000	1.37
+++ upload	17 Mar 2007 18:40:59 -0000
@@ -291,13 +291,6 @@
  	fi
  fi

-if [ "${MKSUMMARY-}" = "yes" -o "${MKSUMMARY-}" = "YES" ]; then
-	echo "upload> Creating summary file..."
-	(cd "${packages}/All" \
-		&& ls -t | grep '\.t[gb]z$' | while read n; do pkg_info -X "$n"; done) \
-		| ${gzip_cmd} > "${packages}"/All/pkg_summary.gz
-fi
-
  cat <<EOF > "$upload_general"
  #! /bin/sh
  set -e