Subject: Re: Document TEST_TARGET
To: Masao Uebayashi <uebayasi@brains.co.jp>
From: Alistair Crooks <agc@pkgsrc.org>
List: tech-pkg
Date: 01/26/2007 18:56:00
On Fri, Jan 26, 2007 at 10:09:04PM +0900, Masao Uebayashi wrote:
> Engrish correction please!

I don't see anything wrong with the English in that sentence, except
maybe "provides" instead of "is providing", but it's not a biggie.

I will admit, however, that it's not that easy to parse for non-native
speakers (which I think was your point), so maybe something like:

	TEST_TARGET is the name of the ${MAKE} target, provided by the
	package, which enables the tests to be executed

But even that's suboptimal from a purist PoV.

Regards,
Alistair

> Index: build/test.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mk/build/test.mk,v
> retrieving revision 1.9
> diff -u -r1.9 test.mk
> --- build/test.mk	15 Dec 2006 12:46:23 -0000	1.9
> +++ build/test.mk	26 Jan 2007 13:02:37 -0000
> @@ -2,6 +2,9 @@
>  #
>  # Package-settable variables:
>  #
> +# TEST_TARGET is the make target name to run the test the package is
> +#	providing.
> +#
>  # TEST_DIRS is the list of directories in which to perform the build
>  #	process.  If the directories are relative paths, then they
>  #	are assumed to be relative to ${WRKSRC}.