Subject: Re: CVS commit: pkgsrc/mk
To: NetBSD Packages Technical Discussion List <firstname.lastname@example.org>
From: Johnny Lam <email@example.com>
Date: 08/04/2006 13:28:36
Roland Illig wrote:
> Module Name: pkgsrc
> Committed By: rillig
> Date: Thu Aug 3 19:12:43 UTC 2006
> Modified Files:
> pkgsrc/mk: bsd.pkg.mk
> pkgsrc/mk/install: deinstall.mk
> Log Message:
> When installing or deinstalling a package, it is not enough to lock the
> WRKDIR against foreign processes. Instead, the PKG_DBDIR is locked,
> preventing other (pkgsrc) processes from modifying the set of installed
> packages while another one is doing that.
> This allows to use "bmake update" efficiently on multi-processor
> machines by just running it in four different package directories.
> Note that the pkg_add and pkg_delete tools may still interfere with this
> locking when they are directly run.
I think this commit is incorrect. The stages for a single package
should keep locking within the package work directory. If you want to
gate the package addition and deletion, then we should have a separate
set of lock macros just for that purpose, and they should be dependent
on the package system flavor.
-- Johnny Lam <firstname.lastname@example.org>