Subject: Re: CVS commit: pkgsrc/mk
To: None <seb@netbsd.org, tech-pkg@NetBSD.org>
From: Dieter Baron <dillo@danbala.tuwien.ac.at>
List: tech-pkg
Date: 06/03/2006 12:29:06
In article <20060603084446.5759E211CA@cvs.netbsd.org> Stoned wrote:
: Hence add trailing part about PKG_OPTIONS_VAR and its value to
: show-options target like the one found in supported-options-message target.

+       @${ECHO} "You can select which build options to use by setting PKG_DEFAU
LT_OPTIONS"
+       @${ECHO} "or the following variable.  Its current value is shown:"
+       @${ECHO} ""
+.    if !defined(${PKG_OPTIONS_VAR})
+       @${ECHO} "      ${PKG_OPTIONS_VAR} (not defined)"
+.    else
+       @${ECHO} "      ${PKG_OPTIONS_VAR} = ${${PKG_OPTIONS_VAR}}"
+.    endif

  I would prefer not printing PKG_OPTION_VAR's current value, the line
above the change already lists the selected options.  And since we
eventually want a recursive target that describes the options of all
dependencies, I would prefer to keep the output short.

  How about

+       @${ECHO} "You can select which build options to use by setting PKG_DEFAU
LT_OPTIONS"
+       @${ECHO} "or "${PKG_OPTIONS_VAR:Q}"."

						yours,
						dillo