Subject: Re: [PATCH] qemu tap support broken on current 3.99.17
To: Hubert Feyrer <hubert@feyrer.de>
From: Quentin Garnier <cube@cubidou.net>
List: tech-pkg
Date: 04/17/2006 13:46:50
--hK8Uo4Yp55NZU70L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 17, 2006 at 03:32:22AM +0200, Hubert Feyrer wrote:
> On Sun, 16 Apr 2006, Luciano R. Furtado wrote:
> >I have attached what I have here.
>=20
> Again: what about NetBSD 2.x and 3.0?

It's irrelevant.  tap(4) is available as a LKM in pkgsrc for those
releases.

> You'll want to add some #ifdef to check that your code for a cloning=20
> tap(4) is really needed. As far as I understand.

No.  What should be done is a configure test for net/if_tap.h, either
found in /usr/include or ${LOCALBASE}/include in case it comes from
pkgsrc, and then the whole tap_open function should depend on that.

But I think I'd rather make qemu depend on netbsd-tap (netbsd-tap's
builtin.mk should do the correct check on NetBSD), and leave the code
simply under __NetBSD__ like it is in Luciano's patch.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

--hK8Uo4Yp55NZU70L
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBREOAKtgoQloHrPnoAQJzZQgAym44XlIWxumgH5bK5UNaOoxpE8kkdyiv
PzfAVStuC+epP/dCFpNoEN6eY8HRjIgq5d+1ILf/iVuBBdrjsqpMdU5FaYq7bH2q
ukMnCakBu4+pBD8/7eo5hWRLMgVb3o3zffvxUQnXlLYNZzsHf7/qnJUt15gG2Xwh
kURuqUCUxJ1yreFDrlpRMI24WaYITEXkDbXJac0KrHZLhfP9Kia9mJddw3deQI8E
3cAhm7c7JgKbEeKJnBTh5cWvzrmnXGqxDTaphb+NBxzfeYLHfFPdmiQEsscTAQ7v
ZpkVYLorE2kww4Jvmnkf+T7Pgnj5SD3e08IiFZ2zXdNJhuIwvNAoXg==
=nf+I
-----END PGP SIGNATURE-----

--hK8Uo4Yp55NZU70L--