Subject: Re: [PATCH] qemu tap support broken on current 3.99.17
To: Luciano Rodrigues Furtado <firstname.lastname@example.org>
From: Quentin Garnier <email@example.com>
Date: 04/16/2006 22:53:44
Content-Type: text/plain; charset=us-ascii
On Sun, Apr 16, 2006 at 05:45:30PM -0300, Luciano Rodrigues Furtado wrote:
> Quentin Garnier wrote:
> >On Sun, Apr 16, 2006 at 05:27:17PM -0300, Luciano Rodrigues Furtado wrot=
> >>Quentin Garnier wrote:
> >>>On Sun, Apr 16, 2006 at 09:43:55PM +0200, Hubert Feyrer wrote:
> >>>>On Sun, 16 Apr 2006, Luciano R. Furtado wrote:
> >>>>>qemu when started with -net tap is crashing on tap_open on=20
> >>>>>NetBSD-current, I had to apply the following patch to get it to work
> >>>>What will this do on NetBSD 2.x and 3.0?
> >>>It's a workaround, not a fix.
> >>should I send-pr so somebody can provide a final solution later on?
> >What qemu is this? The one we have in pkgsrc doesn't have support for
> >our clonable tap(4), and hopefully no NetBSD developer is responsible
> >for code that doesn't check the return value of an ioctl() call.
> That was just a workaround I tried , in order to get qemu working on=20
> current? because it crashes for me on tap_open! What am I missing here?
You mean the ioctl() call is your workaround? Then your diff is
reversed... Save the part where you don't check the return value for
the ioctl(), it is fine, but you have to #ifdef __NetBSD__ it, and leave
the horrid code it replaces in the #else part of that.
Thanks for looking at this. Looking at qemu code is very dangerous for
the eyes, which is why I never got around adding proper support for
tap(4) in it.
Quentin Garnier - firstname.lastname@example.org - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
-----END PGP SIGNATURE-----