Subject: Re: pkg_info: patch to create summary file
To: Dieter Baron <firstname.lastname@example.org>
From: Hubert Feyrer <email@example.com>
Date: 04/12/2006 02:05:41
On Wed, 12 Apr 2006, Dieter Baron wrote:
>> The only thing that's not 100% clear to me is how the distinction between
>> an 'installed' package and one in a package is made - the fname variable
>> seems to be used here. If that assumption is right, maybe that should be
>> documented (i.e. add a comment), or another variable with a better name
>> could be used.
> You're right, that was a quick hack to get the file name into
> show_summary. None of the other show_* function use the file name.
> I'll clean that up.
>> In general, the code seems to be under-commented, esp. that in var.c -
>> guessing what a function does is always painful to me.
> Okay, I'll add function comments where missing.
Should the output format be documented, so tools can use it as interface
definition upon which they can be built? You cited a few tools that rely
on the output of this (or are intended to)...