Subject: Re: mail/metamail/patches/patch-as breaks this package on Solaris
To: None <email@example.com, firstname.lastname@example.org>
From: None <email@example.com>
Date: 02/06/2006 10:49:24
On Mon, 6 Feb 2006 03:19:47 +0100
> (a) It uses functions from stdlib.h, which are otherwise used only as
> implicit prototype. Nasty.
> (b) If that is the only problem, I'm more than willing to conditionalize
> for that. putenv is not standard, after all.
> This code is a nice example of #if cancer and the worst form of it.
If the code chanages made by your patch are simply cosmetic (because #ifdef
looks ugly??) and don't actually fix anything, then it's best to leave out the
patch. Otherwise revise your patch so that the package compiles on other
systems like Solaris, and I'd be happy to test it.