On Fri, Dec 09, 2005 at 12:56:57AM +0100, Lubomir Sedlacik wrote:
> hi,
> 
> On Thu, Dec 08, 2005 at 08:01:22PM +0100, Bernd Ernesti wrote:
> > I would like to commit the following patches, but don't have a 2.0 or
> > 1.6 system for checking if they break something.
> 
> both packages build cleanly on 2.0 and 1.6.2_STABLE.

Good.

> > Index: security/dsniff/Makefile.common
[..]

> this PKGREVISION bump is unnecessary (build-fix only) and in a wrong
> file, anyway.  should've been security/dsniff-nox11/Makefile.

Hmm, yes you are correct that this is unnecessary because i only add some
headers.

> > Index: security/ssldump/Makefile
> > ===================================================================
> > RCS file: /home/source/NetBSD-cvs/main/pkgsrc/security/ssldump/Makefile,v
> > retrieving revision 1.14
> > diff -u -b -b -u -r1.14 Makefile
> > --- security/ssldump/Makefile	22 May 2005 20:08:31 -0000	1.14
> > +++ security/ssldump/Makefile	5 Dec 2005 21:35:34 -0000
> > @@ -2,7 +2,7 @@
> >  #
> >  
> >  DISTNAME=	ssldump-0.9b3
> > -PKGREVISION=	3
> > +PKGREVISION=	4
> 
> again, unnecessary.

I don't think so. The patch adds a new function: SSL_library_init, so it is not
just a compile bugfix.

Bernd