Subject: Re: Proposed changes in the build.conf file
To: Roland Illig <rillig@NetBSD.org>
From: Hubert Feyrer <feyrer@cs.stevens.edu>
List: tech-pkg
Date: 11/28/2005 10:52:51
On Mon, 28 Nov 2005, Roland Illig wrote:
>>>> -FTPx=`date +%Y%m%d.%H%M`
>>>> -FTPURL="pub/NetBSD/pkgstat/${FTPx}"            # relative to ~ftp !
>>>> -FTP="/home/ftp/${FTPURL}"                      # absolute base path
>>>> -FTPHOST="ftp://ftp.machi.ne"                   # host for broken.html
...
>>>> +bc_common_path="`date +%Y%m%d.%H%M`"
>>>> +REPORT_DIR="$HOME/bulk-reports/${bc_common_path}"
>>>> +REPORT_URL="ftp://my.ftp.server.local/pub/NetBSD/pkgstat/${bc_common_path}"
...
> My point is that I don't see why we should keep these different variables for 
> FTPHOST and FTPURL if the only thing they are used for is concatenating them 
> to the URL that will appear in the text/plain report. That's why I suggested 
> to use REPORT_URL instead.

IMHO the former is a bit more readable.

Please note that giving $HOME as an example may be bad.


  - Hubert