Hello,

At Tue, 15 Nov 2005 15:05:54 +0100,
Antoine Reilles wrote:
> 
> On Nov 15, 2005, at 2:40 PM, Kouichirou Hiratsuka wrote:
> > I want to transfer the AAC audio files to my iPod via audio/gtkpod.
> > Currently this does not work.  audio/gtkpod can't recognize these
> > files.  However, I can do this by adding the inclusion of
> > audio/faad2/buildlink3.mk.  This is better to support by default,
> > I think.
> I remember adding the same support for audio/daapd
> At that time, i introduced a faad option to enable AAC support.
> This options is disabled by default.
> Could gtkpod support the same option, for consistency ? (well, the  
> option name could be made more explicit). Why not then enable it by  
> default on both packages ?
> 
I received two objections.  So I've written a patch for options.mk.
The AAC support is disabled by default.

Is this OK to commit?

best regards.
--
 Kouichirou Hiratsuka
   hira@po6.nsk.ne.jp

diff -ruN gtkpod.orig/Makefile gtkpod/Makefile
--- gtkpod.orig/Makefile	2005-11-15 23:19:10.000000000 +0900
+++ gtkpod/Makefile	2005-11-15 23:23:10.000000000 +0900
@@ -19,6 +19,8 @@
 
 BUILDLINK_DEPENDS.gtk2+=	gtk2+>=2.4.0
 
+.include "options.mk"
+
 .include "../../audio/libid3tag/buildlink3.mk"
 .include "../../devel/atk/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"
diff -ruN gtkpod.orig/options.mk gtkpod/options.mk
--- gtkpod.orig/options.mk	1970-01-01 09:00:00.000000000 +0900
+++ gtkpod/options.mk	2005-11-15 23:21:49.000000000 +0900
@@ -0,0 +1,11 @@
+# $NetBSD$
+
+PKG_OPTIONS_VAR=	PKG_OPTIONS.gtkpod
+PKG_SUPPORTED_OPTIONS=	faad
+PKG_SUGGESTED_OPTIONS=
+
+.include "../../mk/bsd.options.mk"
+
+.if !empty(PKG_OPTIONS:Mfaad)
+.  include "../../audio/faad2/buildlink3.mk"
+.endif