On Tue, 15 Nov 2005, Roland Illig wrote:
> 1. Provide only comments:
> #ACROREAD_FONTPATH?=    ${PREFIX}/lib/X11/fonts/TTF
...
> 2. Actually provide a default value:
> PKGSRC_COMPILER?=       gcc
...
> $ pkglint print/acroread7
> ERROR: print/acroread7/Makefile:54: "ACROREAD_FONTPATH" may only
>    be set by the user, not the package.

That sounds useful!


> Does anyone see any objections against changing type 1 definitions to type 2 
> definitions where that makes sense? Which ones need further discussion?

Yes: You're moving the default*value* from the pkg's Makefile to that 
named file, basically spilling pkg data all over pkgsrc. I think that's 
not a good idea. How about simply looking for some assignment to the 
variable?


  - Hubert