Subject: Re: CVS commit: pkgsrc/pkgtools/pkglint
To: Roland Illig <>
From: Alistair Crooks <>
List: tech-pkg
Date: 11/07/2005 22:15:41
On Mon, Nov 07, 2005 at 10:18:30PM +0100, Roland Illig wrote:
> Alistair Crooks wrote:
> >On Sun, Nov 06, 2005 at 10:38:36PM +0000, Roland Illig wrote:
> >
> >>Module Name:	pkgsrc
> >>Committed By:	rillig
> >>Date:		Sun Nov  6 22:38:36 UTC 2005
> >>
> >>Modified Files:
> >>	pkgsrc/pkgtools/pkglint: TODO
> >>
> >>Log Message:
> >>+ check for magic numbers like 0755, 755, 644
> >
> >
> >If this is an attempt to eradicate octal numbers from chmod(1)
> >statements, please do not do this.  There are numerous occasions when
> >absolute modes are needed and essential, and a pkglint warning for
> >those statements would quickly just become noise.
> This is just the TODO list. When I implement an additional check I 
> always run my pkglint-diff program and examine the output carefully. 
> When I feel that most of the uses should be fixed, I commit that change. 
> Otherwise I change the heuristics.
> I think that in most cases these magic numbers can be replaced by 
> ${BINMODE}, ${LIBMODE} or ${DATAMODE}, although I still have to verify 
> this assumption. I'll tell you about it when I have found out.

Off the top of my head, there are such things as setuid programs,
specific directory modes, and others which I can think of.

Please don't add a noise generator - I have enough trouble with
all this fatal white space, and wondering what's so problematic
with it.